This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Add __private_ss to s390 struct tcbhead.
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: GNU C Library <libc-alpha at sourceware dot org>
- Cc: Stefan Liebler <stli at linux dot vnet dot ibm dot com>
- Date: Tue, 12 Jan 2016 10:39:30 -0200
- Subject: Re: [PATCH] Add __private_ss to s390 struct tcbhead.
- Authentication-results: sourceware.org; auth=none
- References: <1451752466-9429-1-git-send-email-koriakin at 0x04 dot net> <5694EFDA dot 5060505 at linux dot vnet dot ibm dot com>
Yes, the initial patch was sent prior the release dates. The only bit I
would some comments is why adding '__glibc_reserved1' fields (alignment
maybe?).
On 12-01-2016 10:21, Stefan Liebler wrote:
> This is okay for s390.
>
> Adhemerval, is this okay for 2.23?
>
> It is needed to enable split-stack support on s390 (See gcc bug #68191).
>
> Bye Stefan
>
> On 01/02/2016 05:34 PM, Marcin KoÅcielnicki wrote:
>> Preparation for gcc -fsplit-stack support (gcc bug #68191). The new
>> field is basically identical to the one on x86. Its TCB offset needs
>> to be constant, as it'll be hardcoded in gcc.
>>
>> * sysdeps/s390/nptl/tls.h: Add __private_ss to struct tcbhead.
>> ---
>> ChangeLog | 4 ++++
>> sysdeps/s390/nptl/tls.h | 4 ++++
>> 2 files changed, 8 insertions(+)
>>
>> diff --git a/ChangeLog b/ChangeLog
>> index 8c339d2..e39e2ce 100644
>> --- a/ChangeLog
>> +++ b/ChangeLog
>> @@ -1,3 +1,7 @@
>> +2015-01-02 Marcin KoÅcielnicki <koriakin@0x04.net>
>> +
>> + * sysdeps/s390/nptl/tls.h: Add __private_ss to struct tcbhead.
>> +
>> 2016-01-01 Mike Frysinger <vapier@gentoo.org>
>>
>> [BZ #15421]
>> diff --git a/sysdeps/s390/nptl/tls.h b/sysdeps/s390/nptl/tls.h
>> index 28a2119..0e61154 100644
>> --- a/sysdeps/s390/nptl/tls.h
>> +++ b/sysdeps/s390/nptl/tls.h
>> @@ -53,7 +53,11 @@ typedef struct
>> int gscope_flag;
>> #ifndef __ASSUME_PRIVATE_FUTEX
>> int private_futex;
>> +#else
>> + int __glibc_reserved1;
>> #endif
>> + /* GCC split stack support. */
>> + void *__private_ss;
>> } tcbhead_t;
>>
>> # ifndef __s390x__
>>
>