This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3] Add pretty printers for the NPTL lock types
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Martin Galvan <martin dot galvan at tallertechnologies dot com>
- Cc: libc-alpha at sourceware dot org, Tom Tromey <tom at tromey dot com>, Torvald Riegel <triegel at redhat dot com>, Pedro Alves <palves at redhat dot com>, Daniel Gutson <daniel dot gutson at tallertechnologies dot com>
- Date: Fri, 8 Jan 2016 10:05:00 -0500
- Subject: Re: [PATCH v3] Add pretty printers for the NPTL lock types
- Authentication-results: sourceware.org; auth=none
- References: <CAOKbPbbVud=gru917mXYfnOnQ9nCCY1vR4fvyU8JpRVzaGe5bw at mail dot gmail dot com> <1446939548-30602-1-git-send-email-martin dot galvan at tallertechnologies dot com> <20160108082325 dot GJ25548 at vapier dot lan> <CAOKbPbafgBAjZ8trEV_cxKcQ-h2vep2YRBmD+Nb8HGwk73oAGA at mail dot gmail dot com> <568FC8A3 dot 8050105 at redhat dot com> <CAOKbPbY0Hj6BYHaBPqQxAO2D_2X4hBYzXjPzHwwAvBY2h=X7bg at mail dot gmail dot com>
On 01/08/2016 09:50 AM, Martin Galvan wrote:
> On Fri, Jan 8, 2016 at 11:33 AM, Carlos O'Donell <carlos@redhat.com> wrote:
>> Woah, wait, DejaGNU? Why? We don't have any DejaGNU infrastructure
>> in glibc and adding it will only complicate this change. Unless you
>> mean to add them to the gdb testing?
>
> Indeed, there's not :) I was working on adding a minimal
> infrastructure only for these tests. Needless to say, if there's any
> way whatsoever to avoid doing that, I'll be more than happy to go with
> it.
>
> In fact, I was hoping that this could go in without unit tests, but I
> understand they're necessary. Any suggestions on a simpler way to test
> these is more than welcome.
>
You can use any script, or application wired into glibc's build
infrastructure and it executes as a test and honours exit code numbers
we use then it can be used.
We have lots of complex tests that use scripts to setup and run the
tests and that complexity is hidden on a per-test basis rather than
being imposed on all tests.
Cheers,
Carlos.