This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3] Add pretty printers for the NPTL lock types


On 01/08/2016 08:31 AM, Martin Galvan wrote:
> On Fri, Jan 8, 2016 at 5:23 AM, Mike Frysinger <vapier@gentoo.org> wrote:
>> On 07 Nov 2015 20:39, Martin Galvan wrote:
>>> --- /dev/null
>>> +++ b/nptl/nptl-printers.py
>>> +import sys
>>
>> as the linter points out, this is unused, so you should drop it
>>
>> can you post a v4 with all the comments fixed ?
>>
>>> +MUTEX_TYPES = {
>>> +    PTHREAD_MUTEX_NORMAL: ('Type', 'Normal'),
>>> +    PTHREAD_MUTEX_RECURSIVE: ('Type', 'Recursive'),
>>> +    PTHREAD_MUTEX_ERRORCHECK: ('Type', 'Error check'),
>>> +    PTHREAD_MUTEX_ADAPTIVE_NP: ('Type', 'Adaptive')
>>> +}
>>
>> imo, we should have dangling commas with lists/dicts/tuples like we do
>> in C with arrays.
>> -mike
> 
> Thanks for the reply. Most of the answers on this are in this thread:
> 
> https://sourceware.org/ml/libc-alpha/2015-11/msg00257.html
> 
> Right now this is on a bit of a hiatus because other glibc maintainers
> requested for unit tests for this. I'm working on them using DejaGNU,
> but I don't know when they will be finished. I'll send in a v4 when
> it's done.

Woah, wait, DejaGNU? Why? We don't have any DejaGNU infrastructure
in glibc and adding it will only complicate this change. Unless you
mean to add them to the gdb testing?

Cheers,
Carlos.
 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]