Re: [PATCH] Test for lazy tls descriptor initialization

[Mike Frysinger <vapier at gentoo dot org>]

On 17 Nov 2015 16:51, Szabolcs Nagy wrote:
> +AC_CACHE_CHECK(for compiler option to enable TLS descriptors,
> +	       libc_cv_cc_tlsdesc, [dnl
> +libc_cv_cc_tlsdesc=-no-tlsdesc-support

should use "no" rather than an arbitrary nonsense string.  this is a cache
var, so people running configure would have to do:
	libc_cv_cc_tlsdesc=-no-tlsdesc-support
instead of the more common:
	libc_cv_cc_tlsdesc=no

> --- /dev/null
> +++ b/elf/tst-lazytls.h
> @@ -0,0 +1,11 @@
> +#define A(n) \

all these files need proper comment block headers

> +#include <assert.h>

you can't use assert in tests because it writes to stderr.
you'll need to use printf/exit yourself.

> +	extern void f##n (void); \

style on these files is wrong -- indentation needs to use spaces rather
than tabs
-mike

Attachment: signature.asc
Description: Digital signature