This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] __libc_lock_define_initialized: Always initialize the lock
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: GNU C Library <libc-alpha at sourceware dot org>
- Cc: Florian Weimer <fweimer at redhat dot com>
- Date: Wed, 25 Nov 2015 17:26:33 -0200
- Subject: Re: [PATCH] __libc_lock_define_initialized: Always initialize the lock
- Authentication-results: sourceware.org; auth=none
- References: <5654DA50 dot 5060002 at redhat dot com> <56560152 dot 1020708 at linaro dot org> <56560AEA dot 3080602 at redhat dot com>
On 25-11-2015 17:24, Florian Weimer wrote:
> On 11/25/2015 07:43 PM, Adhemerval Zanella wrote:
>
>> LGTM. Since you touching this, I think it is worthwhile to cleanup the
>> LLL_LOCK_INITIALIZER{_LOCKED,_WAITERS} definition (i386, sparc, and
>> x86_64 redefines it to same value).
>
> Do you suggest to remove the architecture-specific #defines?
Yes, since right now they are equal to default one at
sysdeps/nptl/lowlevellock.h, and I see not reason to have different
definition for each architecture.
>
> Thanks,
> Florian
>