This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [COMMITTED] tile: define __NO_LONG_DOUBLE_MATH


On Tue, 24 Nov 2015, Chris Metcalf wrote:

> This avoids build failures in the tests, and matches what is in
> bits/mathdef.h.
> 
> Update the libc and libm abilist files to include __finitel,
> __isinfl, and __isnanl.

The abilist changes need more explanation.  Did you previously have ABI 
test failures for the baselines being incorrect?  How did such incorrect 
baselines arise?  Were the symbols in fact exported at version GLIBC_2.12 
in the binaries of that version that were the reason for starting symbols 
at that version rather than 2.15?  Unless those 2.12 binaries had these 
symbols, they should not be exported at version GLIBC_2.12.  You could add 
them to GLIBC_2.23 for tile, but really there should be no need for those 
symbols at all in the __NO_LONG_DOUBLE_MATH case so the only case for 
doing so would be consistency between architectures; it would be better 
for the preferred approach to be that these symbols aren't exported in 
that case, as with __issignalingl, with backwards compatibility only for 
existing such architectures that export them.  (The public interfaces 
finitel, isinfl, isnanl of course should be exported as they already were 
- although as legacy interfaces no new versions of them should be added 
for TS 18661-3 types, only versions such as __isnanf128 when actually 
needed.)

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]