This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Fix math_private.h multiple include guards [committed]
- From: Andreas Schwab <schwab at linux-m68k dot org>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Mon, 23 Nov 2015 10:46:14 +0100
- Subject: Re: Fix math_private.h multiple include guards [committed]
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 10 dot 1511202346460 dot 22057 at digraph dot polyomino dot org dot uk> <m2ziy73ekg dot fsf at linux-m68k dot org> <alpine dot DEB dot 2 dot 10 dot 1511230937540 dot 5401 at digraph dot polyomino dot org dot uk>
Joseph Myers <joseph@codesourcery.com> writes:
> On Sat, 21 Nov 2015, Andreas Schwab wrote:
>
>> Joseph Myers <joseph@codesourcery.com> writes:
>>
>> > * sysdeps/arm/math_private.h [!_MATH_PRIVATE_H]: Change guard to
>> > [!ARM_MATH_PRIVATE_H].
>> > [!ARM_MATH_PRIVATE_H] (ARM_MATH_PRIVATE_H): Define macro.
>>
>> That should be _ARM_MATH_PRIVATE_H, etc.
>
> This is an internal header, not an installed header, so I see no need for
> the leading underscore (and there is no consistency in that regard in
> headers unchanged by my patch, e.g. AARCH64_MATH_PRIVATE_H but
> _PPC_MATH_PRIVATE_H_).
We should standardize on underscored guards for all headers.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."