This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Fix ldbl-128ibm strtold overflow handling (bug 14551) [committed]
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: <libc-alpha at sourceware dot org>
- Date: Mon, 16 Nov 2015 10:53:42 +0000
- Subject: Re: Fix ldbl-128ibm strtold overflow handling (bug 14551) [committed]
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 10 dot 1511131204180 dot 20244 at digraph dot polyomino dot org dot uk> <mvmegfqw9ta dot fsf at hawking dot suse dot de>
On Mon, 16 Nov 2015, Andreas Schwab wrote:
> Joseph Myers <joseph@codesourcery.com> writes:
>
> > Tested for powerpc. Committed.
>
> In file included from ../include/sys/param.h:1:0,
> from ../sysdeps/generic/hp-timing-common.h:41,
> from ../sysdeps/powerpc/powerpc64/hp-timing.h:44,
> from ../nptl/descr.h:27,
> from ../sysdeps/powerpc/nptl/tls.h:58,
> from ../include/errno.h:27,
> from ../sysdeps/ieee754/ldbl-128ibm/mpn2ldbl.c:21:
> ../misc/sys/param.h:102:0: error: "MIN" redefined [-Werror]
> #define MIN(a,b) (((a)<(b))?(a):(b))
> ^
> In file included from ../sysdeps/ieee754/ldbl-128ibm/mpn2ldbl.c:19:0:
> ./gmp-impl.h:68:0: note: this is the location of the previous definition
> #define MIN(l,o) ((l) < (o) ? (l) : (o))
My inclination would be that gmp-impl.h should be made to include
sys/param.h to get definitions of MIN and MAX, rather than defining its
own. Although moving the GMP includes down in mpn2ldbl.c should also work
since gmp-impl.h uses #ifndef around its definitions of those macros.
--
Joseph S. Myers
joseph@codesourcery.com