This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] [BZ #19178] Add a test for prelink output

From: Szabolcs Nagy <szabolcs dot nagy at arm dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>, Joseph Myers <joseph at codesourcery dot com>
Cc: Szabolcs Nagy <nsz at port70 dot net>, GNU C Library <libc-alpha at sourceware dot org>
Date: Wed, 11 Nov 2015 15:44:16 +0000
Subject: Re: [PATCH] [BZ #19178] Add a test for prelink output
Authentication-results: sourceware.org; auth=none
References: <20151107145502 dot GA959 at intel dot com> <20151107155458 dot GF8500 at port70 dot net> <CAMe9rOpR8mimKYCbn5ZE60PwT1W-zR7NLKibpyND=wQE9UWr6Q at mail dot gmail dot com> <CAMe9rOqKfWtQYOrRmpGS0RVpeLHNfFP=nK7Y3dK4qJdwjUXjuw at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1511102134390 dot 31840 at digraph dot polyomino dot org dot uk> <CAMe9rOq-Y1ubj7r8zmKrHsNvxx-wG5uE08V_0h8vY82dq9i8ow at mail dot gmail dot com>

On 11/11/15 00:12, H.J. Lu wrote:

On Tue, Nov 10, 2015 at 1:43 PM, Joseph Myers <joseph@codesourcery.com> wrote:

On Tue, 10 Nov 2015, H.J. Lu wrote:

On Mon, Nov 9, 2015 at 6:42 AM, H.J. Lu <hjl.tools@gmail.com> wrote:

On Sat, Nov 7, 2015 at 7:54 AM, Szabolcs Nagy <nsz@port70.net> wrote:

* H.J. Lu <hongjiu.lu@intel.com> [2015-11-07 06:55:02 -0800]:

This test applies to i386 and x86_64 which set R_386_GLOB_DAT and
R_X86_64_GLOB_DAT to ELF_RTYPE_CLASS_EXTERN_PROTECTED_DATA.  OK for
master?


why is the test x86 specific?

extern protected data handling and LD_TRACE_PRELINKING
seem to be generic.


It only applies to GLOB_DAT relocation.  Not all targets have it
and I have only x86 to test.


I will check it in and backport the fix with this this to 2.22 branch.


I see no sign of consensus for an x86-specific test here.  I too think the
test should be written in an architecture-independent way, with a way for
architectures for which it is inapplicable to disable it.


Here is a patch to run it on targets with GLOB_DAT reloc.


i have no more complaints, thanks.

References:
- [PATCH] [BZ #19178] Add a test for prelink output
  - From: H.J. Lu
- Re: [PATCH] [BZ #19178] Add a test for prelink output
  - From: Szabolcs Nagy
- Re: [PATCH] [BZ #19178] Add a test for prelink output
  - From: H.J. Lu
- Re: [PATCH] [BZ #19178] Add a test for prelink output
  - From: H.J. Lu
- Re: [PATCH] [BZ #19178] Add a test for prelink output
  - From: Joseph Myers
- Re: [PATCH] [BZ #19178] Add a test for prelink output
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]