This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] hurd: Define and pass UTIME_NOW and UTIME_OMIT to new file_utimens RPC
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Samuel Thibault <samuel dot thibault at gnu dot org>
- Cc: libc-alpha at sourceware dot org, bug-hurd at gnu dot org, Flávio Cruz <flaviocruz at gmail dot com>
- Date: Mon, 9 Nov 2015 10:56:19 -0800 (PST)
- Subject: Re: [PATCH] hurd: Define and pass UTIME_NOW and UTIME_OMIT to new file_utimens RPC
- Authentication-results: sourceware.org; auth=none
- References: <20151012223057 dot GB2989 at var dot home>
Don't repeat all that code. Make a shared helper function _hurd_futimens
or suchlike.
> 2015-09-20 Flávio Cruz <flaviocruz@gmail.com>
>
> Define and pass UTIME_NOW and UTIME_OMIT to new file_utimens RPC.
>
> * sysdeps/mach/hurd/bits/stat.h (UTIME_NOW, UTIME_OMIT): New macros.
No blank line there. A ChangeLog paragraph (sequence with no blank lines)
covers a single logical change. If you want to put a descriptive sentence
(not associated with a particular file) at the top of the change, then it
is the first line of the paragraph.
> --- a/sysdeps/mach/hurd/bits/stat.h
> +++ b/sysdeps/mach/hurd/bits/stat.h
> @@ -246,6 +246,10 @@ struct stat64
> # define SF_NOUNLINK 0x00100000 /* file may not be removed or renamed */
> # define SF_SNAPSHOT 0x00200000 /* snapshot inode */
>
> +/* Time flags for futimens. */
> +#define UTIME_NOW -1 /* corresponds to the current time */
> +#define UTIME_OMIT -2 /* target time is omitted */
These should be under #ifdef __USE_ATFILE as they are in other bits/stat.h
files. These are not "flags". They are special values for the tv_nsec
field. Two spaces after a period.