This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] S390: Call direct system calls for socket operations.
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: libc-alpha at sourceware dot org
- Date: Wed, 21 Oct 2015 09:07:07 -0200
- Subject: Re: [PATCH] S390: Call direct system calls for socket operations.
- Authentication-results: sourceware.org; auth=none
- References: <mvinhp$mak$1 at ger dot gmane dot org> <561CF109 dot 9030403 at linaro dot org> <mvl26o$43c$1 at ger dot gmane dot org> <n07iql$4q3$1 at ger dot gmane dot org>
LGTM.
On 21-10-2015 06:36, Stefan Liebler wrote:
> ping
>
> On 10/14/2015 10:02 AM, Stefan Liebler wrote:
>>
>> On 10/13/2015 01:54 PM, Adhemerval Zanella wrote:
>>> I would prefer to not add another arch-specific implementation, but
>>> instead
>>> use something like __ASSUME_ACCEPT4_FOR_ACCEPT_SYSCALL and use accept4
>>> directly in sysdeps/unix/sysv/linux/accept.c. Same for recv and send.
>>
>> That sounds reasonable. Here is the updated patch.
>>
>> ---
>> 2015-10-14 Stefan Liebler <stli@linux.vnet.ibm.com>
>>
>> * sysdeps/unix/sysv/linux/s390/kernel-features.h:
>> (__ASSUME_*_SYSCALL) Define new macros.
>> * sysdeps/unix/sysv/linux/s390/s390-64/syscalls.list:
>> Remove socketcall syscalls.
>> * sysdeps/unix/sysv/linux/accept.c (__libc_accept):
>> Use accept4 if defined __ASSUME_ACCEPT4_FOR_ACCEPT_SYSCALL.
>> * sysdeps/unix/sysv/linux/recv.c (__libc_recv):
>> Use recvfrom if defined __ASSUME_RECVFROM_FOR_RECV_SYSCALL.
>> * sysdeps/unix/sysv/linux/send.c (__libc_send):
>> Use sendto if defined __ASSUME_SENDTO_FOR_SEND_SYSCALL.
>