Re: [PATCH v4] timezone: add a configure flag to disable program install

[ricaljasan <ricaljasan at pacific dot net>]

On 10/16/2015 09:39 PM, Mike Frysinger wrote:
> On 20 Sep 2015 21:31, ricaljasan wrote:
>> On 09/18/2015 02:49 PM, Mike Frysinger wrote:
>>> diff --git a/INSTALL b/INSTALL
> 
> INSTALL is a generated file, so spacing is out of our control.
> consult the source texi file for any possible suggestions.
> 
>>> diff --git a/configure b/configure
> 
> same goes for this

Cool, thank you for pointing that out.  I should've realized that about
configure, but didn't know that about INSTALL.

> here's a patch for the things i thought were def wrong
> -mike
> 
> --- a/configure.ac
> +++ b/configure.ac
> @@ -161,7 +161,7 @@ AC_ARG_ENABLE([profile],
>  	      [profile=no])
>  AC_ARG_ENABLE([timezone-tools],
>  	      AC_HELP_STRING([--disable-timezone-tools],
> -			     [do not install timezone tools (if using external ones) @<:@default=install@:>@]),
> +			     [do not install timezone tools @<:@default=install@:>@]),
>  	      [enable_timezone_tools=$enableval],
>  	      [enable_timezone_tools=yes])
>  AC_SUBST(enable_timezone_tools)
> --- a/manual/install.texi
> +++ b/manual/install.texi
> @@ -159,9 +159,9 @@ so that they can be invoked directly.
>  
>  @item --disable-timezone-tools
>  By default, timezone related utilities (@command{zic}, @command{zdump},
> -and @command{tzselect}) are installed with glibc.  If you are building
> +and @command{tzselect}) are installed with @theglibc{}.  If you are building
>  these independently (e.g. by using the @samp{tzcode} package), then this
> -option will allow disabling the install of these too.
> +option will allow disabling the install of these.
>  
>  Note that you need to make sure the external tools are kept in sync with
>  the versions that @theglibc{} expects as the data formats may change over

SGTM.  I know a number of my suggestions were a matter of taste, but I
think you grabbed the important ones.

Rical