This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
RE: [PATCH 2/2] Remove ancient GCC string inlines
- From: "Wilco Dijkstra" <wdijkstr at arm dot com>
- To: "'Joseph Myers'" <joseph at codesourcery dot com>
- Cc: "'GNU C Library'" <libc-alpha at sourceware dot org>
- Date: Tue, 13 Oct 2015 16:08:25 +0100
- Subject: RE: [PATCH 2/2] Remove ancient GCC string inlines
- Authentication-results: sourceware.org; auth=none
- References: <000401d102aa$8db859e0$a9290da0$ at com> <alpine dot DEB dot 2 dot 10 dot 1510091558180 dot 20476 at digraph dot polyomino dot org dot uk> <000801d102b1$3e4f33e0$baed9ba0$ at com> <alpine dot DEB dot 2 dot 10 dot 1510091657190 dot 20476 at digraph dot polyomino dot org dot uk> <000901d104e0$069f65b0$13de3110$ at com> <alpine dot DEB dot 2 dot 10 dot 1510121131000 dot 16894 at digraph dot polyomino dot org dot uk> <000a01d104ed$0b7a9c00$226fd400$ at com> <alpine dot DEB dot 2 dot 10 dot 1510121256230 dot 30255 at digraph dot polyomino dot org dot uk> <000b01d10518$befeab10$3cfc0130$ at com> <alpine dot DEB dot 2 dot 10 dot 1510121809310 dot 6267 at digraph dot polyomino dot org dot uk>
> Joseph Myers wrote:
> On Mon, 12 Oct 2015, Wilco Dijkstra wrote:
>
> > * string/string-inlines.c (__STRING2_COPY_TYPE): Add, moved from string2.h.
>
> > * string/bits/string2.h (__STRING2_COPY_TYPE): Remove.
>
> Does this move of __STRING2_COPY_TYPE mean the patch fixes [BZ #18712]?
It does indeed. It also ensures that future changes of _STRING_ARCH_unaligned no
longer cause backwards compatibility issues due to the inline functions using
different ABIs depending on the _STRING_ARCH_unaligned setting (I didn't find a
BZ entry for this one).
Wilco