This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/6] Use INLINE_SYSCALL_ERROR_RETURN


"H.J. Lu" <hjl.tools@gmail.com> writes:

> diff --git a/sysdeps/unix/sysv/linux/mmap64.c b/sysdeps/unix/sysv/linux/mmap64.c
> index 1c9d3c1..8d5b0a4 100644
> --- a/sysdeps/unix/sysv/linux/mmap64.c
> +++ b/sysdeps/unix/sysv/linux/mmap64.c
> @@ -46,7 +46,7 @@ __mmap64 (void *addr, size_t len, int prot, int
> flags, int fd, off64_t offset)
>      }
>  #endif
>    if (offset & ((1 << page_shift) - 1))
> -    return (void *) INLINE_SYSCALL_ERROR_RETURN (EINVAL);
> +    return (void *) (ptrdiff_t) INLINE_SYSCALL_ERROR_RETURN (EINVAL);

That's doesn't look like a good change, since you lose the warning if
INLINE_SYSCALL_ERROR_RETURN returns something different from the size of
a pointer.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]