This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] 18969 - multiple string test failures due to missing locale dependencies
- From: Florian Weimer <fweimer at redhat dot com>
- To: Andreas Schwab <schwab at suse dot de>, Martin Sebor <msebor at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 12 Oct 2015 13:00:38 +0200
- Subject: Re: [PATCH] 18969 - multiple string test failures due to missing locale dependencies
- Authentication-results: sourceware.org; auth=none
- References: <560471F5 dot 9080800 at gmail dot com> <mvmh9lwzaxk dot fsf at hawking dot suse dot de>
On 10/12/2015 11:35 AM, Andreas Schwab wrote:
> Martin Sebor <msebor@gmail.com> writes:
>
>> diff --git a/string/Makefile b/string/Makefile
>> index 8424a61..0d8df0b 100644
>> --- a/string/Makefile
>> +++ b/string/Makefile
>> @@ -75,4 +75,13 @@ ifeq ($(run-built-tests),yes)
>> $(objpfx)tst-svc-cmp.out: tst-svc.expect $(objpfx)tst-svc.out
>> cmp $^ > $@; \
>> $(evaluate-test)
>> +
>> +LOCALES = de_DE.UTF-8 en_US.ISO-8859-1 en_US.UTF-8 tr_TR.ISO-8859-9
>> tr_TR.UTF-8
>> +include ../gen-locales.mk
>> +
>> +$(objpfx)test-strcasecmp.out: $(gen-locales)
>> +$(objpfx)test-strncasecmp.out: $(gen-locales)
>> +$(objpfx)tst-strxfrm.out: $(gen-locales)
>> +$(objpfx)tst-strxfrm2.out: $(gen-locales)
>
> What happens if there are multiple calls to gen-locales.sh in parallel
> from different directories?
Are you concerned that make will not serialize them properly because the
build system relies on recursive make invocations?
This could indeed be a problem. I'm not sure what's the best way to
tackle that.
Florian