This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCHv3] powerpc: ABI change - add HWCAP/HWCAP2/platform info to TCB
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: munroesj at linux dot vnet dot ibm dot com, Carlos Eduardo Seo <cseo at linux dot vnet dot ibm dot com>
- Cc: Peter Bergner <bergner at vnet dot ibm dot com>, Roland McGrath <roland at hack dot frob dot com>, Joseph Myers <joseph at codesourcery dot com>, GNU C Library <libc-alpha at sourceware dot org>, Tulio Machado <tuliom at linux dot vnet dot ibm dot com>
- Date: Fri, 9 Oct 2015 16:19:10 -0400
- Subject: Re: [PATCHv3] powerpc: ABI change - add HWCAP/HWCAP2/platform info to TCB
- Authentication-results: sourceware.org; auth=none
- References: <4BE991CB-F601-4D63-A416-5991FE870FC4 at linux dot vnet dot ibm dot com> <alpine dot DEB dot 2 dot 10 dot 1509232114070 dot 10585 at digraph dot polyomino dot org dot uk> <B650304C-6207-46AC-B6A8-FA29959B305D at linux dot vnet dot ibm dot com> <alpine dot DEB dot 2 dot 10 dot 1509232141250 dot 10585 at digraph dot polyomino dot org dot uk> <1443046986 dot 23503 dot 68 dot camel at otta> <alpine dot DEB dot 2 dot 10 dot 1509232234500 dot 10585 at digraph dot polyomino dot org dot uk> <1443050731 dot 23503 dot 78 dot camel at otta> <alpine dot DEB dot 2 dot 10 dot 1509232340470 dot 10585 at digraph dot polyomino dot org dot uk> <1443057751 dot 13186 dot 6 dot camel at otta> <alpine dot DEB dot 2 dot 10 dot 1509240126140 dot 10585 at digraph dot polyomino dot org dot uk> <1443058522 dot 13186 dot 9 dot camel at otta> <1443654009 dot 4885 dot 4 dot camel at oc7878010663> <B2EB15A6-FEB5-4DBA-8719-0BAA5B65EF5E at linux dot vnet dot ibm dot com> <5615CD5D dot 1080409 at redhat dot com> <3C6704AA-1037-487A-BE68-BFACCB6A15C4 at linux dot vnet dot ibm dot com> <1444317883 dot 12222 dot 4 dot camel at oc7878010663>
On 10/08/2015 11:24 AM, Steven Munroe wrote:
>>> (c) Avoid custom dl-support.c
>>>
>>> Are you sure you can't avoid this? Can we add AT_PLATFORM directly to the
>>> case statement used in _dl_aux_init?
>>
>> I suppose we could. Iâll see if that doesnât break anything.
>>
> Carlos we keep going around on this. When we do what you suggest it
> stops working for static or dynamic linking.
>
> We have to do something like this to get both static and dynamic linking
> to work (ie get the TCB fields initialized before we run the library
> init and C++ CTORs).
My suggestion is not to remove it, but to move it into generic code
to avoid a POWER-specific change. We should be handling AT_PLATFORM
copying in a generic way, that way it enables it for all arches, and
POWER doesn't have to maintain a local machine change.
I've spoken to Carlos a bit on IRC about this, and I think we have
consensus on how to fix this.
Cheers,
Carlos.