This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
RE: [PATCH 2/2] Remove ancient GCC string inlines
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Wilco Dijkstra <wdijkstr at arm dot com>
- Cc: 'GNU C Library' <libc-alpha at sourceware dot org>
- Date: Fri, 9 Oct 2015 17:01:09 +0000
- Subject: RE: [PATCH 2/2] Remove ancient GCC string inlines
- Authentication-results: sourceware.org; auth=none
- References: <000401d102aa$8db859e0$a9290da0$ at com> <alpine dot DEB dot 2 dot 10 dot 1510091558180 dot 20476 at digraph dot polyomino dot org dot uk> <000801d102b1$3e4f33e0$baed9ba0$ at com>
On Fri, 9 Oct 2015, Wilco Dijkstra wrote:
> You wrote in http://sourceware.org/ml/libc-alpha/2015-05/msg00770.html:
> "(sysdeps/i386/string-inlines.c can be ignored or removed since plain i386
> is no longer supported; only string/string-inlines.c and
> sysdeps/i386/i486/string-inlines.c are relevant.)"
That was before HJ moved the i386/i486 contents up a directory level.
sysdeps/i386/string-inlines.c is what used to be
sysdeps/i386/i486/string-inlines.c at the time I wrote that.
> Looking at the x86 build, string-inlines.o is indeed
> string/string-inlines.c so That confirms sysdeps/i386/string-inlines.c
> is not built at all. No idea what magic ensures this, but that's what I
> get...
Well, sysdeps/i386/string-inlines.c should be built. My 32-bit x86 builds
clearly show "gcc -m32 ../sysdeps/i386/string-inlines.c -c ..." in the
build logs.
> I did full testsuite runs of course, and the only failures are the usual
> suspects
> tests.sum:FAIL: elf/check-abi-libc
ABI test failures are not usual suspects! (Remember to build with
--prefix=/usr to avoid bug 14664.) This is the key test to show up
problems with this patch; you should never ignore failures of this test.
--
Joseph S. Myers
joseph@codesourcery.com