This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCHv3] powerpc: ABI change - add HWCAP/HWCAP2/platform info to TCB
- From: Peter Bergner <bergner at vnet dot ibm dot com>
- To: "Carlos O'Donell" <carlos at redhat dot com>
- Cc: Carlos Eduardo Seo <cseo at linux dot vnet dot ibm dot com>, munroesj at linux dot vnet dot ibm dot com, Roland McGrath <roland at hack dot frob dot com>, Joseph Myers <joseph at codesourcery dot com>, GNU C Library <libc-alpha at sourceware dot org>, Tulio Machado <tuliom at linux dot vnet dot ibm dot com>, "Steven J. Munroe" <sjmunroe at us dot ibm dot com>
- Date: Thu, 08 Oct 2015 06:50:17 -0500
- Subject: Re: [PATCHv3] powerpc: ABI change - add HWCAP/HWCAP2/platform info to TCB
- Authentication-results: sourceware.org; auth=none
- References: <4BE991CB-F601-4D63-A416-5991FE870FC4 at linux dot vnet dot ibm dot com> <alpine dot DEB dot 2 dot 10 dot 1509232114070 dot 10585 at digraph dot polyomino dot org dot uk> <B650304C-6207-46AC-B6A8-FA29959B305D at linux dot vnet dot ibm dot com> <alpine dot DEB dot 2 dot 10 dot 1509232141250 dot 10585 at digraph dot polyomino dot org dot uk> <1443046986 dot 23503 dot 68 dot camel at otta> <alpine dot DEB dot 2 dot 10 dot 1509232234500 dot 10585 at digraph dot polyomino dot org dot uk> <1443050731 dot 23503 dot 78 dot camel at otta> <alpine dot DEB dot 2 dot 10 dot 1509232340470 dot 10585 at digraph dot polyomino dot org dot uk> <5615CD5D dot 1080409 at redhat dot com>
On Wed, 2015-10-07 at 21:56 -0400, Carlos O'Donell wrote:
> However, it doesn't appear that __ppc_get_hwcap or __ppc_get_at_platform
> generate any references to __parse_hwcap_and_convert_at_platform? These
> two functions as added in the manual could be used by applications
> directly by including the platform header and calling those functions.
> Such applications would have no such references to __parse* and as such
> would not be protected by the dynamic loader library version checking.
Remind me again why we're exporting those? I know the initial expected
usage had GCC's builtin_cpu_init() function calling those, but now that
you've changed things so that the TCB is initialized very early, do
we really need to export anything, other than the versioned symbol
__parse_hwcap_and_convert_at_platform? Maybe we do and I'm just not
remembering.
Peter