This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/2] Introduce pthread_self_t
- From: Florian Weimer <fweimer at redhat dot com>
- To: rth at twiddle dot net
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 8 Oct 2015 11:12:54 +0200
- Subject: Re: [PATCH 1/2] Introduce pthread_self_t
- Authentication-results: sourceware.org; auth=none
- References: <1444276705-6797-1-git-send-email-rth at twiddle dot net> <1444276705-6797-2-git-send-email-rth at twiddle dot net>
On 10/08/2015 05:58 AM, Richard Henderson wrote:
> --- a/sysdeps/ia64/nptl/tls.h
> +++ b/sysdeps/ia64/nptl/tls.h
> @@ -46,7 +46,8 @@ typedef struct
> void *__private;
> } tcbhead_t;
>
> -register struct pthread *__thread_self __asm__("r13");
> +typedef struct pthread pthread_self_t;
> +register pthread_self_t *__thread_self __asm__("r13");
I'm not sure if this hunk is philosophically correct because the object
pointed to by __thread_self has to be within the same address space. It
does not make a functional difference, of course.
The rest looks good.
This needs some sort of a changelog entry. Listing only the changed
files is fine with me (but others may disagree and request a full
changelog).
Florian