This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [patch] Fix build error for tst-printf-bz18872 on arm/aarch64 and s390
- From: Florian Weimer <fweimer at redhat dot com>
- To: Paul Pluzhnikov <ppluzhnikov at google dot com>
- Cc: GLIBC Devel <libc-alpha at sourceware dot org>
- Date: Thu, 8 Oct 2015 07:15:19 +0200
- Subject: Re: [patch] Fix build error for tst-printf-bz18872 on arm/aarch64 and s390
- Authentication-results: sourceware.org; auth=none
- References: <CALoOobN6U4bEXMB3UdW7=6OuH0mJW+iA7+xE8+AiZtVGg3knAw at mail dot gmail dot com> <5614CEDB dot 5040709 at redhat dot com> <CALoOobMEvHOLK2LQ+UtKch2PZ52anx7=QS9QNC9sZU1iDCD-NA at mail dot gmail dot com> <CALoOobMH9RNcUe913EtBnCKuEN=-OoQXYr27VctH2qPdmvYCLQ at mail dot gmail dot com> <CALoOobOCxqzsG7H5_M4Cc6gCPzRGH-aDs7F_avYy=gvgZ47pqw at mail dot gmail dot com> <CALoOobMEO3sxuxZWtcou-=Dz14RJq-=yPE66ORAqPMzhBT9shw at mail dot gmail dot com>
On 10/08/2015 07:09 AM, Paul Pluzhnikov wrote:
> On Wed, Oct 7, 2015 at 10:06 PM, Paul Pluzhnikov <ppluzhnikov@google.com> wrote:
>> On Wed, Oct 7, 2015 at 8:13 PM, Paul Pluzhnikov <ppluzhnikov@google.com> wrote:
>>
>> The attribute nicely works around the aarch64 break.
>>
>> Thanks!
>>
>> 2015-10-07 Paul Pluzhnikov <ppluzhnikov@google.com>
>>
>> * stdio-common/tst-printf-bz18872.sh: Use attribute optimize instead of
>> #pragma optimize.
>
> And again with space-before-paren.
One space still missing (although the space rule does not apply to (all)
macros, only to function calls, so it's slightly unclear what's correct
for attributes).
Can you say in the commit message that this is to work around breakage
on aarch64?
Florian