This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 01/13] nptl: Add NPTL cases for cancellation failures cases
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 7 Oct 2015 13:54:51 -0700 (PDT)
- Subject: Re: [PATCH 01/13] nptl: Add NPTL cases for cancellation failures cases
- Authentication-results: sourceware.org; auth=none
- References: <1444234995-9542-1-git-send-email-adhemerval dot zanella at linaro dot com> <1444234995-9542-2-git-send-email-adhemerval dot zanella at linaro dot com>
The top line of a new file should be a descriptive comment.
New test cases should have clear comments describing exactly what they are
testing.
Don't predeclare locals, just use C99 inline declarations.
Make sure all lines are under 80 characters.
You sample errno in the local variable E but then test errno itself instead
of testing E. As there are no other calls between sampling errno and using
its value in the argument to printf, there is no real need for the local.
But if you want to have the local, use it consistently.
Since these two cases have almost identical code, make one of them just
#include the other with a #define rather than duplicating all the code.
If these tests pass with the existing code, then send them separately so
it's clear they can safely go in before the whole patch series is reviewed.
Thanks,
Roland