This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][BZ 18960] setlocale.c: Mark *_used symbols as unaligned.


On 28 Sep 2015 16:52, Florian Weimer wrote:
> On 09/28/2015 04:18 PM, Rich Felker wrote:
> > Can you explain how/why you think this is needed? char has no
> > alignment requirements (inherently) so as far as I can tell, the
> > compiler may not make any alignment assumptions about an extern object
> > of type char.
> 
> s390(x) expects all top-level objects in the data segment to be aligned
> to at least 2.  As far as I can tell, this is not explicitly mentioned
> in the psABI supplement, but it is heavily implied by .align directives
> and use of the lalr instruction.

how does that bubble in here though ?  does locale/localeinfo.h need to update
_NL_CURRENT_DEFINE to use helpers from libc-symbols.h ?  this seems to be
patching a single symptom point rather than addressing the source.
-mike

Attachment: signature.asc
Description: Digital signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]