This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [BZ #18433] Check file access/existence before forking.


There are various places where you're missing the space before the '(' of 
a function call.

POSIX specifies that no library function sets errno to 0.

Typically when using a fallback from __ASSUME_PIPE2 the first fallback 
would be to try calling __pipe2 even if !__ASSUME_PIPE2 - and if it fails 
with an errno setting other than ENOSYS, then treat that as an error from 
which you don't try to fall back, but if it fails with ENOSYS, fall back 
to __pipe.  In addition, such code in the !__ASSUME_PIPE2 case uses the 
variable __have_pipe2 (0 if pipe2 availability unknown, 1 if it's been 
tried and didn't fail with ENOSYS, -1 if it's been tried and did fail with 
ENOSYS.  See various existing examples.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]