This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [v3] Add math-inline benchmark
- From: Siddhesh Poyarekar <sid at reserved-bit dot com>
- To: Wilco Dijkstra <wdijkstr at arm dot com>, 'GNU C Library' <libc-alpha at sourceware dot org>
- Date: Thu, 17 Sep 2015 10:59:13 +0530
- Subject: Re: [v3] Add math-inline benchmark
- Authentication-results: sourceware.org; auth=none
- References: <000001d0da84$c84110f0$58c332d0$ at com> <1442387104 dot 10242 dot 26 dot camel at reserved-bit dot com> <001c01d0f094$1fafb7e0$5f0f27a0$ at com>
On Wed, 2015-09-16 at 16:26 +0100, Wilco Dijkstra wrote:
> I previously posted a patch to enable inlines in math.h which replace
> the
> GLIBC internal inlines. I also posted a patch to rename all uses of
> __isinf_ns to isinf so they also use the new inline. I am going to
> post a
> patch remove all the math_private inlines as they are never used
> after
> these changes.
>
> So these functions are not duplicated, and it is necessary to add a
> copy
> to benchmark the old implementation. Ie. the only duplication is
> EXTRACT_WORDS64, which seems fairly minor.
>
> I've updated my patch with your other comments, see attached.
Looks good to me.
Thanks,
Siddhesh