This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 0/4] Avoid PIC and optimize i386 syscalls
- From: Zack Weinberg <zackw at panix dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 10 Sep 2015 09:58:45 -0400
- Subject: Re: [PATCH 0/4] Avoid PIC and optimize i386 syscalls
- Authentication-results: sourceware.org; auth=none
- References: <20150910131217 dot GA9542 at gmail dot com>
I'm not the person who has to approve these, I'm only reading 'em out
of curiosity, but, the way you've organized this patch series makes it
difficult to find the interesting changes. I'm not even clear on how
many there *are*. It would be better if you separated all of the
mechanical changes -- so for instance you would have one patch that
adds both the generic and the i386 INLINE_SYSCALL_ERROR_RETURN *but
does not use them anywhere*, and then a second patch, which ideally
could be summarized as a sed script, to introduce all the uses. And
so on.
zw