This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH][BZ #18778] Clear DF_1_NODELETE flag only for dlopen failed library.

From: Maxim Ostapenko <m dot ostapenko at partner dot samsung dot com>
To: Florian Weimer <fweimer at redhat dot com>, "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: Andreas Schwab <schwab at suse dot de>, Pavel Kopyl <p dot kopyl at samsung dot com>, Yury Gribov <y dot gribov at samsung dot com>, Roland McGrath <roland at hack dot frob dot com>, GNU C Library <libc-alpha at sourceware dot org>, Carlos O'Donell <carlos at redhat dot com>, Viacheslav Garbuzov <v dot garbuzov at samsung dot com>
Date: Fri, 04 Sep 2015 12:39:41 +0300
Subject: Re: [PATCH][BZ #18778] Clear DF_1_NODELETE flag only for dlopen failed library.
Authentication-results: sourceware.org; auth=none
References: <54BD4F65 dot 2090108 at samsung dot com> <CAMe9rOq++pD-ugdYFEte49v8TLZEM505J+=WzPTOT_Lo-MdDHQ at mail dot gmail dot com> <5565C862 dot 1040003 at samsung dot com> <CAMe9rOo7TStj3SX8OK8s3H3G=2Pyr1WKTW=R-=SzVFBWY8PF0A at mail dot gmail dot com> <5566395A dot 3090605 at samsung dot com> <CAMe9rOp4Jrz4AE3-C5VmJ0PLmxoST3phyEQt3t59ag6UGbimBw at mail dot gmail dot com> <5567892C dot 4070004 at samsung dot com> <5568A408 dot 2080903 at samsung dot com> <5592AB91 dot 2050709 at samsung dot com> <CAMe9rOoK64VuNfgZ-8_BTqes0tJcpc55atKw1k6ewBTwFzuGKg at mail dot gmail dot com> <5595C0F8 dot 3060300 at samsung dot com> <CAMe9rOof9j6RwGgNGuxXUgBnYXK0c_UAp3zN2Ne4JhHqiZMFEQ at mail dot gmail dot com> <559B829C dot 8080700 at samsung dot com> <CAMe9rOom4ttO2cGYGovagHpu3zy4L7qn+7E4jm7k=5rD+xgNaQ at mail dot gmail dot com> <559BFDDC dot 4010604 at samsung dot com> <mvmpp30o2nw dot fsf at hawking dot suse dot de> <55C4D58D dot 8010307 at partner dot samsung dot com> <CAMe9rOq8_3A0ogN2riC32r+QazmJ5kW+5jg22x9_1z1uZaShVQ at mail dot gmail dot com> <55C89171 dot 8090307 at partner dot samsung dot com> <55E96349 dot 6070708 at redhat dot com> <55E9651C dot 4030701 at partner dot samsung dot com> <55E96620 dot 9060109 at redhat dot com>

On 04/09/15 12:36, Florian Weimer wrote:

On 09/04/2015 11:32 AM, Maxim Ostapenko wrote:

On 04/09/15 12:24, Florian Weimer wrote:

On 08/10/2015 01:56 PM, Maxim Ostapenko wrote:

This patch fixes BZ #18778 issue by moving l->l_flags_1 &=
~DF_1_NODELETE out of loop through all loaded libraries and performs
this action only on inconsistent one.

No regressions on x86_64-unknown-linux-gnu, testcase is attached, OK for
master?

This patch deletes elf/tst-znodelete-zlib.cc.  Is this intentional?

Yeah, according to this Andreas's comment, I've deleted it.

Pavel Kopyl <p.kopyl@samsung.com> writes:
   elf/tst-znodelete-zlib.cc     |    6 +++++

That file is not used anywhere.
Andreas.

Perhaps I just forgot to mention this in CL and commit message. Did you
meet some problem here?

No, I just noticed the ChangeLog inconsistency.  I've committed the
attached patch to address that.


Oh, sorry for inconvenience. Thanks!

References:
- Re: [PATCH][BZ #18778] Clear DF_1_NODELETE flag only for dlopen failed library.
  - From: Florian Weimer
- Re: [PATCH][BZ #18778] Clear DF_1_NODELETE flag only for dlopen failed library.
  - From: Maxim Ostapenko
- Re: [PATCH][BZ #18778] Clear DF_1_NODELETE flag only for dlopen failed library.
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]