This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 08/08] nptl: arm: Fix Race conditions in pthread cancellation (BZ#12683)
- From: Phil Blundell <pb at pbcl dot net>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 02 Sep 2015 00:08:46 +0100
- Subject: Re: [PATCH 08/08] nptl: arm: Fix Race conditions in pthread cancellation (BZ#12683)
- Authentication-results: sourceware.org; auth=none
- References: <55E4C300 dot 9080800 at linaro dot org>
On Mon, 2015-08-31 at 18:11 -0300, Adhemerval Zanella wrote:
> --- /dev/null
> +++ b/sysdeps/unix/sysv/linux/arm/syscall_cancel.S
> @@ -0,0 +1,69 @@
> +/* Cancellable syscall wrapper - aarch64 version.
I guess this should say "arm version".
> + .thumb
> + .syntax unified
I think this (at least the .thumb part) should be inside #ifdef
__thumb2__. Otherwise this will break compiling on ARMv4 which I think
otherwise still works.
> +
> +ENTRY (__syscall_cancel_arch)
> + .fnstart
> + mov ip,sp
> + stmfd sp!,{r4,r5,r6,r7,lr}
> + .save {r4,r5,r6,r7,lr}
Why are you stacking r7 and lr here?
p.