This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix broken overflow check in posix_fallocate
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Paul Eggert <eggert at cs dot ucla dot edu>, Florian Weimer <fweimer at redhat dot com>, libc-alpha at sourceware dot org
- Date: Fri, 28 Aug 2015 14:12:37 -0400
- Subject: Re: [PATCH] Fix broken overflow check in posix_fallocate
- Authentication-results: sourceware.org; auth=none
- References: <1440571321-20287-1-git-send-email-eggert at cs dot ucla dot edu> <55DD6115 dot 2040000 at redhat dot com> <55DFB8EB dot 5000005 at redhat dot com> <55E01FCF dot 9050507 at redhat dot com> <55E07C13 dot 2090503 at cs dot ucla dot edu> <55E09784 dot 3010608 at redhat dot com> <55E09FFA dot 6010500 at cs dot ucla dot edu>
On 08/28/2015 01:52 PM, Paul Eggert wrote:
> Carlos O'Donell wrote:
>> * Does anyone mind if we use the terse "Likewise" format?
>
> There must be some misunderstanding here, as the "Likewise" format is *less* terse than the format I used. That is, I did this:
>
>> + Fix broken overflow check in posix_fallocate
>> + * sysdeps/posix/posix_fallocate.c (posix_fallocate):
>> + * sysdeps/posix/posix_fallocate64.c (__posix_fallocate64_l64):
>> + Fix parenthesization typo.
This is what I called the `terse "Likewise"` format.
> rather than this:
>
>> + Fix broken overflow check in posix_fallocate
>> + * sysdeps/posix/posix_fallocate.c (posix_fallocate):
>> + Fix parenthesization typo.
>> + * sysdeps/posix/posix_fallocate64.c (__posix_fallocate64_l64):
>> + Likewise.
This is the standard one.
Does that clarify things?
c.