This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH] Fix broken overflow check in posix_fallocate
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Paul Eggert <eggert at cs dot ucla dot edu>, Florian Weimer <fweimer at redhat dot com>, libc-alpha at sourceware dot org
- Date: Fri, 28 Aug 2015 13:16:52 -0400
- Subject: Re: [PATCH] Fix broken overflow check in posix_fallocate
- Authentication-results: sourceware.org; auth=none
- References: <1440571321-20287-1-git-send-email-eggert at cs dot ucla dot edu> <55DD6115 dot 2040000 at redhat dot com> <55DFB8EB dot 5000005 at redhat dot com> <55E01FCF dot 9050507 at redhat dot com> <55E07C13 dot 2090503 at cs dot ucla dot edu>
On 08/28/2015 11:19 AM, Paul Eggert wrote:
> Florian Weimer wrote:
>> That part I had seen before, but I also expected something like this:
>> + Fix broken overflow check in posix_fallocate
>> + * sysdeps/posix/posix_fallocate.c (posix_fallocate):
>> + Fix parenthesization typo.
>> + * sysdeps/posix/posix_fallocate64.c (__posix_fallocate64_l64):
>> + Likewise.
> Nowadays the "Likewise" style is considered old-fashioned in the
> other projects I hang out in. Although it's fine and is still used on
> occasion, it feels a bit like writing "whereas" or "henceforth". I
> don't know whether the newer style has been formally documented
> anywhere, but it's quite common and it is terser.
If you wouldn't mind, please stick to the existing project format for
this patch, but do start a new thread and ask:
* Does anyone mind if we support descriptive text in the ChangeLog?
* Does anyone mind if we use the terse "Likewise" format?
Then we'll get some yays and nays and update the Contribution Checklist.
I don't see why anyone would object, but I'd rather we talk about it,