This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH] Fix broken overflow check in posix_fallocate
- From: Paul Eggert <eggert at cs dot ucla dot edu>
- To: Florian Weimer <fweimer at redhat dot com>, Carlos O'Donell <carlos at redhat dot com>, libc-alpha at sourceware dot org
- Date: Fri, 28 Aug 2015 08:19:47 -0700
- Subject: Re: [PATCH] Fix broken overflow check in posix_fallocate
- Authentication-results: sourceware.org; auth=none
- References: <1440571321-20287-1-git-send-email-eggert at cs dot ucla dot edu> <55DD6115 dot 2040000 at redhat dot com> <55DFB8EB dot 5000005 at redhat dot com> <55E01FCF dot 9050507 at redhat dot com>
Florian Weimer wrote:
That part I had seen before, but I also expected something like this:
+ Fix broken overflow check in posix_fallocate
+ * sysdeps/posix/posix_fallocate.c (posix_fallocate):
+ Fix parenthesization typo.
+ * sysdeps/posix/posix_fallocate64.c (__posix_fallocate64_l64):
Nowadays the "Likewise" style is considered old-fashioned in the other projects
I hang out in. Although it's fine and is still used on occasion, it feels a bit
like writing "whereas" or "henceforth". I don't know whether the newer style
has been formally documented anywhere, but it's quite common and it is terser.