This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2][BZ 13690] Do not violate mutex destruction requirements.
- From: Andreas Schwab <schwab at suse dot de>
- To: Torvald Riegel <triegel at redhat dot com>
- Cc: David Miller <davem at davemloft dot net>, libc-alpha at sourceware dot org, carlos at redhat dot com
- Date: Mon, 24 Aug 2015 09:32:30 +0200
- Subject: Re: [PATCH v2][BZ 13690] Do not violate mutex destruction requirements.
- Authentication-results: sourceware.org; auth=none
- References: <1436905273 dot 19451 dot 14 dot camel at localhost dot localdomain> <20150715 dot 160555 dot 934366773890383260 dot davem at davemloft dot net> <mvm1tg8chxq dot fsf at hawking dot suse dot de> <1440362686 dot 27492 dot 66 dot camel at localhost dot localdomain>
Torvald Riegel <triegel@redhat.com> writes:
> diff --git a/sysdeps/unix/sysv/linux/lowlevellock-futex.h b/sysdeps/unix/sysv/linux/lowlevellock-futex.h
> index 59f6627..e1a9c58 100644
> --- a/sysdeps/unix/sysv/linux/lowlevellock-futex.h
> +++ b/sysdeps/unix/sysv/linux/lowlevellock-futex.h
> @@ -54,8 +54,13 @@
> #if IS_IN (libc) || IS_IN (rtld)
> /* In libc.so or ld.so all futexes are private. */
> # ifdef __ASSUME_PRIVATE_FUTEX
> -# define __lll_private_flag(fl, private) \
> - ((fl) | FUTEX_PRIVATE_FLAG)
> +# define __lll_private_flag(fl, private) \
> + ({ \
> + /* Prevent warnings in callers of this macro. */ \
> + int __lll_private_flag_priv __attribute__ ((unused)); \
> + __lll_private_flag_priv = private; \
Macro parameters should be parenthesized.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."