This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Don't use -Wno-uninitialized in math/
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Steve Ellcey <sellcey at imgtec dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Fri, 21 Aug 2015 16:10:28 +0000
- Subject: Re: Don't use -Wno-uninitialized in math/
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 10 dot 1508201800380 dot 30940 at digraph dot polyomino dot org dot uk> <1440173079 dot 23512 dot 36 dot camel at ubuntu-sellcey>
On Fri, 21 Aug 2015, Steve Ellcey wrote:
> On Thu, 2015-08-20 at 18:00 +0000, Joseph Myers wrote:
> > The uninitialized variable warnings in math/ having been fixed for all
> > the supported floating-point formats, this patch removes the use of
> > -Wno-uninitialized there, continuing with the goal of avoiding -Wno-
> > options in makefiles as far as possible..
> >
> > Tested for x86_64 and x86 (full build and testsuite runs), and for
> > powerpc and mips64 (verified that glibc builds without errors).
> > Committed.
>
> I am seeing a mips32 build failure (using Top-of-tree GCC) with this
> change:
>
> In file included from ../soft-fp/soft-fp.h:321:0,
> from ../soft-fp/fmatf4.c:30,
mips32 shouldn't be using fmatf4; sysdeps/mips/ieee754/s_fmal.c even has a
#error to make sure of this. Do you mean mips64?
There are also diagnostic control macros in fmatf4.c specifically to
disable this warning, so you'll need to look at why those aren't working
for you.
--
Joseph S. Myers
joseph@codesourcery.com