This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH 1/5] Clean pthread types namespace for all archs.
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Juan Manuel Torres Palma <j dot m dot torrespalma at gmail dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>
- Date: Fri, 21 Aug 2015 01:18:14 +0000
- Subject: Re: [PATCH 1/5] Clean pthread types namespace for all archs.
- Authentication-results: sourceware.org; auth=none
- References: <1439217470-23427-1-git-send-email-j dot m dot torrespalma at gmail dot com> <1439217470-23427-2-git-send-email-j dot m dot torrespalma at gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1508132335460 dot 7713 at digraph dot polyomino dot org dot uk> <CAD82F-pgh1-oGj7z0Ls2PDSL2iEGE=PC3KGRwoAHN+GVt_erWg at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1508171432400 dot 29836 at digraph dot polyomino dot org dot uk> <CAD82F-qr6sBxxD6SBmMcqiGCz+1qD-Q0V_xCUS=OoN-iLrv3TQ at mail dot gmail dot com>
On Fri, 21 Aug 2015, Juan Manuel Torres Palma wrote:
> > Well, don't say $ARCH (just give the name that will be found within the
> > sysdeps search path, allowing the possibility that in some cases this may
> > depend on both the architecture and the OS)
> Then should I add that comment to each architecture specific
> thread-shared-types.h? I really don't get this. Could you give me an
No, put the comment in the default thread-shared-types.h only. But where
your comment says "$ARCH/bits/thread-shared-types.h. Defines ..." just say
"bits/thread-shared-types.h. Defines ...", with no mention of "$ARCH".
The interface for thread-shared-types.h is not that it is
architecture-specific - it's that it's a sysdeps header, and copies of
that header might correspond to architectures, operating systems or some
combination thereof. Similarly, don't say "arch-specific" or anything
like that in the default header, because the particular axes of variation
that happen to be used by the correct copies of the header are not part of
Joseph S. Myers