This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH v2] Remove isinf uses that rely on signed return value

> Joseph Myers wrote:
> On Thu, 20 Aug 2015, Wilco Dijkstra wrote:
> > I found a few more cases where isinf is used to get the signbit. Clean
> > these up to improve the readability and maintainability and allow
> > inlining. Generated code is virtually identical once isinf is inlined
> > using the GCC builtin.
> >
> > OK for commit?
> What exactly are the dependencies of this patch and their review state?
> My understanding is that first we need to get in benchmarks for the
> classification macros.  Then, given such benchmarks checked in, the change
> to use the built-in functions can be considered on the basis of evidence
> from those benchmarks.  Then, with the built-in functions in use, we can
> consider patches like this based on such comparisons of code generated.

That's correct. The inlining patch was already approved, so everything
is waiting for an OK for the latest version of the math-inlines benchmark

However there is no strict dependency here - this patch will work correctly
without inlining of isinf and cause no regressions for typical inputs.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]