This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH v2] Remove isinf uses that rely on signed return value
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Wilco Dijkstra <wdijkstr at arm dot com>
- Cc: 'GNU C Library' <libc-alpha at sourceware dot org>
- Date: Thu, 20 Aug 2015 14:39:36 +0000
- Subject: Re: [PATCH v2] Remove isinf uses that rely on signed return value
- Authentication-results: sourceware.org; auth=none
- References: <000201d0db54$373461e0$a59d25a0$ at com>
On Thu, 20 Aug 2015, Wilco Dijkstra wrote:
> I found a few more cases where isinf is used to get the signbit. Clean
> these up to improve the readability and maintainability and allow
> inlining. Generated code is virtually identical once isinf is inlined
> using the GCC builtin.
> OK for commit?
What exactly are the dependencies of this patch and their review state?
My understanding is that first we need to get in benchmarks for the
classification macros. Then, given such benchmarks checked in, the change
to use the built-in functions can be considered on the basis of evidence
from those benchmarks. Then, with the built-in functions in use, we can
consider patches like this based on such comparisons of code generated.
Joseph S. Myers