This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [2.23 PATCH] Desupport regexp.h (bug 18681)

On 08/17/2015 09:56 AM, Mike Frysinger wrote:
> On 17 Aug 2015 09:30, Zack Weinberg wrote:
>> On 08/17/2015 04:50 AM, Stefan Liebler wrote:
>>> i get the following warning while compiling misc/regexp.c:
>>> gcc regexp.c -c -Wall -Werror -Wno-error=undef -Wundef
>>> ...
>>> In file included from regexp.c:28:0:
>>> ../include/shlib-compat.h:45:10: warning: "ABI_libc_GLIBC_2_23" is not
>>> defined [-Wundef]
>> ...
>>> The generated abi-versions.h file does not contain a define for
>>> ABI_libc_GLIBC_2_23.
>> What architecture? abi-versions.h does contain that define for me:
>> $ grep libc_GLIBC_2_23 abi-versions.h
>> #define ABI_libc_GLIBC_2_23	25	/* support GLIBC_2.23 */
>> #define VERSION_libc_GLIBC_2_23	GLIBC_2.23
>> $ ../glibc/scripts/config.guess
>> x86_64-unknown-linux-gnu
> i think each subdir Versions file has to be consistent with the code in it.  
> since misc/ was updated, misc/Versions has to cover it explicitly.
> -mike

One of the big benefits of -Wundef -Werror was to prevent this kind
of error from happening. We made the build use -Wundef, and that way
if you failed to define the right things in Versions it would fail
the build (see the problem we had with librt symbols in 2.18 that
prompted the entire -Wundef work).

How was Zack able to build glibc at all?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]