This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [patch] Fix BZ #18660 -- overflow in getusershell
- From: Tobias StÃckmann <tobias at stoeckmann dot org>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: GLIBC Devel <libc-alpha at sourceware dot org>, Paul Pluzhnikov <ppluzhnikov at gmail dot com>
- Date: Mon, 17 Aug 2015 17:53:03 +0200 (CEST)
- Subject: Re: [patch] Fix BZ #18660 -- overflow in getusershell
- Authentication-results: sourceware.org; auth=none
- References: <CAPC3xaqdOk4EWQJEiBLidfVxSx1iH5F9k_DTZDamkjQR1xZ3Gw at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1508171058110 dot 9234 at digraph dot polyomino dot org dot uk> <833414989 dot 49643 dot 1439825616327 dot JavaMail dot open-xchange at oxbsltgw00 dot schlund dot de> <alpine dot DEB dot 2 dot 10 dot 1508171547220 dot 29836 at digraph dot polyomino dot org dot uk>
- Reply-to: Tobias StÃckmann <tobias at stoeckmann dot org>
> On August 17, 2015 at 5:48 PM Joseph Myers <joseph@codesourcery.com> wrote:
> It's smaller than statb.st_size / 3 * sizeof (char *) (or the new adjusted
> version thereof), since sizeof (char *) is 4 or 8 for configurations
> supported by glibc.
I wonder what makes me blind towards "sizeof (char *)" these days.
You are right, of course.