This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] getsysstats: use sysinfo() instead of parsing /proc/meminfo
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Rasmus Villemoes <rv at rasmusvillemoes dot dk>
- Cc: <libc-alpha at sourceware dot org>, Linus Torvalds <torvalds at linux-foundation dot org>
- Date: Thu, 13 Aug 2015 14:53:22 +0000
- Subject: Re: [PATCH] getsysstats: use sysinfo() instead of parsing /proc/meminfo
- Authentication-results: sourceware.org; auth=none
- References: <1439471796-17003-1-git-send-email-rv at rasmusvillemoes dot dk>
On Thu, 13 Aug 2015, Rasmus Villemoes wrote:
> +sysinfo_mempages(unsigned long int num, unsigned int mem_unit)
Missing space before '('. Appears several times in this patch.
How was this patch tested? I'd have expected linknamespace test failures
from the calls to sysinfo (that is, I'd expect you to need to make sysinfo
into a weak alias for __sysinfo and call __sysinfo here to avoid such
namespace issues).
--
Joseph S. Myers
joseph@codesourcery.com