This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][BZ #17250] Static dlopen default library search path fix
- From: Andreas Schwab <schwab at suse dot de>
- To: "Maciej W. Rozycki" <macro at linux-mips dot org>
- Cc: Roland McGrath <roland at hack dot frob dot com>, OndÅej BÃlka <neleai at seznam dot cz>, Allan McRae <allan at archlinux dot org>, libc-alpha at sourceware dot org
- Date: Wed, 05 Aug 2015 15:00:06 +0200
- Subject: Re: [PATCH][BZ #17250] Static dlopen default library search path fix
- Authentication-results: sourceware.org; auth=none
- References: <20131017174710 dot GA4993 at domone dot podge> <20131025210328 dot 39E69746B6 at topped-with-meat dot com> <alpine dot DEB dot 1 dot 10 dot 1310252347350 dot 12843 at tp dot orcam dot me dot uk> <20140116203847 dot GB20838 at domone dot podge> <alpine dot DEB dot 1 dot 10 dot 1401172303320 dot 4268 at tp dot orcam dot me dot uk> <20140117233957 dot 64E307441B at topped-with-meat dot com> <alpine dot DEB dot 1 dot 10 dot 1401271320170 dot 4268 at tp dot orcam dot me dot uk> <alpine dot DEB dot 1 dot 10 dot 1401291054290 dot 4268 at tp dot orcam dot me dot uk> <mvmfv3zxkhk dot fsf at hawking dot suse dot de> <alpine dot LFD dot 2 dot 20 dot 1508041538290 dot 1410 at eddie dot linux-mips dot org> <mvmvbcvvz1b dot fsf at hawking dot suse dot de> <alpine dot LFD dot 2 dot 20 dot 1508041948170 dot 1410 at eddie dot linux-mips dot org> <mvmmvy6rl6s dot fsf at hawking dot suse dot de> <alpine dot LFD dot 2 dot 20 dot 1508051343490 dot 1410 at eddie dot linux-mips dot org>
"Maciej W. Rozycki" <macro@linux-mips.org> writes:
> On Wed, 5 Aug 2015, Andreas Schwab wrote:
>
>> > So the solution is to leave `.l_flags_1' clear in the static link map,
>> > and I can see `__builtin_expect' has been since changed in elf/dl-load.c
>> > to `__glibc_unlikely' already so nothing to do here; obviously I must have
>> > not been the only one getting confused here.
>>
>> The __builtin_expect -> __glibc_(un)likely change was a cleanup, nothing
>> about getting confused.
>
> Hmm, what was the purpose of introducing `__glibc_(un)likely' then?
A nicer interface.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."