This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Adjust _Unwind_Word in unwind.h to version in libgcc.
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Stefan Liebler <stli at linux dot vnet dot ibm dot com>, libc-alpha at sourceware dot org
- Date: Fri, 31 Jul 2015 09:18:46 -0400
- Subject: Re: [PATCH] Adjust _Unwind_Word in unwind.h to version in libgcc.
- Authentication-results: sourceware.org; auth=none
- References: <mp7b4a$8q4$1 at ger dot gmane dot org> <mvmfv48906x dot fsf at hawking dot suse dot de> <mp809u$9mo$1 at ger dot gmane dot org>
On 07/28/2015 09:32 AM, Stefan Liebler wrote:
> On 07/28/2015 10:05 AM, Andreas Schwab wrote:
>> I see three uses of _Unwind_Word as a pointer: in
>> sysdeps/generic/unwind-dw2.c _Unwind_GetGR and _Unwind_SetGR and in
>> sysdeps/generic/unwind-pe.h read_uleb128. Is the new definition correct
>> for them?
>>
>> Andreas.
>>
>
> sysdeps/generic/unwind-pe.h read_uleb128:
> _Unwind_Word has now a size of 4bytes on s390-32 (esa or zarch mode),
> which can store a pointer, which has 4bytes on s390-32 (esa or zarch mode). On s390-64 both _Unwind_Word and a pointer have a size of 8 bytes.
>
> sysdeps/generic/unwind-dw2.c _Unwind_GetGR and _Unwind_SetGR:
> Here the 4 bytes on s390-32 (esa or zarch mode) is correct, too.
> Without this patch, 8 bytes would be dereferenced on s390-32 (zarch-mode), which is incorrect.
> For s390-64, 8 bytes is correct.
>
Does this mean s390 has 2 supported ABIs for 32-bit?
If so, we should adjust:
https://sourceware.org/glibc/wiki/ABIList?highlight=%28ABI%29#s390
Cheers,
Carlos.