This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
RE: [PATCH][PING] Inline C99 math functions
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Wilco Dijkstra <wdijkstr at arm dot com>
- Cc: 'GNU C Library' <libc-alpha at sourceware dot org>
- Date: Wed, 22 Jul 2015 19:47:42 +0000
- Subject: RE: [PATCH][PING] Inline C99 math functions
- Authentication-results: sourceware.org; auth=none
- References: <001c01d0bd7e$25a147c0$70e3d740$ at com> <alpine dot DEB dot 2 dot 10 dot 1507221514520 dot 21570 at digraph dot polyomino dot org dot uk> <003501d0c497$3aaa27c0$affe7740$ at com>
On Wed, 22 Jul 2015, Wilco Dijkstra wrote:
> > I don't see an updated ChangeLog entry (with the [BZ #N] notation I
> > requested). Please include the ChangeLog entry with each patch
> > submission.
>
> It was still in the quotes. Something like this?
>
> 2015-07-xx Wilco Dijkstra <wdijkstr@arm.com>
>
> * math/Makefile: Build test-snan.c with -fsignaling-nans.
> * math/math.h (fpclassify): Use __builtin_fpclassify when
> available. (signbit): Use __builtin_signbit(f/l).
> (isfinite): Use__builtin_isfinite. (isnormal): Use
> __builtin_isnormal. (isnan): Use __builtin_isnan - fixes [BZ #17441].
> (isinf): Use __builtin_isinf_sign - fixes [BZ #15367].
That's not the style used (and your line breaks are all wrong).
<TAB>[BZ #N]<LF> at the start of the ChangeLog entry, after the initial
author-date line and blank line and before the lines describing changes to
each file.
--
Joseph S. Myers
joseph@codesourcery.com