This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix sparc build
- From: Roland McGrath <roland at hack dot frob dot com>
- To: David Miller <davem at davemloft dot net>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 15 Jul 2015 15:45:53 -0700 (PDT)
- Subject: Re: [PATCH] Fix sparc build
- Authentication-results: sourceware.org; auth=none
- References: <20150715 dot 152157 dot 1923341079641036124 dot davem at davemloft dot net>
> * sysdeps/sparc/sparc32/sparcv9/bits/atomic.h (atomic_spin_nop): Remove space from
This line is too long.
> +ifeq ($(subdir),nscd)
> +routines += cpu_relax
> +endif
I think this merits a comment explaining that atomic_spin_nop (or you could
just say "direct uses of our internal <atomic.h> interfaces") requires
cpu_relax and that nscd uses those internal interfaces directly.
Otherwise looks fine and I think it clearly falls under Carlos's rules for
freeze-time commits without his explicit approval.
Thanks,
Roland