This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[COMMITTED PATCH] Remove unnecessary mutex locks from tst-tls-atexit test case
- From: Siddhesh Poyarekar <siddhesh at redhat dot com>
- To: libc-alpha at sourceware dot org
- Date: Fri, 10 Jul 2015 23:29:38 +0530
- Subject: [COMMITTED PATCH] Remove unnecessary mutex locks from tst-tls-atexit test case
- Authentication-results: sourceware.org; auth=none
The locks don't synchronize with anything - they were likely
introduced initially to synchronize with some main thread code, but
that is no longer evident.
Committed as obvious.
Siddhesh
---
ChangeLog | 3 +++
stdlib/tst-tls-atexit.c | 3 ---
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 8ee61d6..0c7fc2c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
2015-07-10 Siddhesh Poyarekar <siddhesh@redhat.com>
+ * stdlib/tst-tls-atexit.c (load): Remove unnecessary mutex
+ locks.
+
* stdlib/tst-tls-atexit.c (load): Avoid boolean coercion.
2015-07-10 Torvald Riegel <triegel@redhat.com>
diff --git a/stdlib/tst-tls-atexit.c b/stdlib/tst-tls-atexit.c
index 7a69722..5ee04a8 100644
--- a/stdlib/tst-tls-atexit.c
+++ b/stdlib/tst-tls-atexit.c
@@ -29,12 +29,10 @@
#include <errno.h>
void *handle;
-pthread_mutex_t m = PTHREAD_MUTEX_INITIALIZER;
void *
load (void *u)
{
- pthread_mutex_lock (&m);
handle = dlopen ("$ORIGIN/tst-tls-atexit-lib.so", RTLD_LAZY);
if (handle == NULL)
{
@@ -55,7 +53,6 @@ load (void *u)
/* This should not unload the DSO. If it does, then the thread exit will
result in a segfault. */
dlclose (handle);
- pthread_mutex_unlock (&m);
return NULL;
}
--
2.4.3