This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Use "|" instead of "+" when combine the _IO_LINE_BUF and _IO_UNBUFFERED flags
- From: Siddhesh Poyarekar <siddhesh at redhat dot com>
- To: Feng Gao <gfree dot wind at gmail dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 8 Jul 2015 13:52:05 +0530
- Subject: Re: [PATCH] Use "|" instead of "+" when combine the _IO_LINE_BUF and _IO_UNBUFFERED flags
- Authentication-results: sourceware.org; auth=none
- References: <CA+6hz4qE5L-6LQEvVawdKtXXrqpP-c-VO1SmGtamRJUoRWYLRQ at mail dot gmail dot com> <20150707073145 dot GK13549 at spoyarek dot pnq dot redhat dot com> <CA+6hz4r4FjfTN5+AfM=x7_2xCC-3_FMeniMHdYNufBRrd4g8Lg at mail dot gmail dot com> <20150707162858 dot GR13549 at spoyarek dot pnq dot redhat dot com> <CA+6hz4omaZ2wjwCS1cKOXs27=p0oijUjtP9-8PVbyuDimQDtow at mail dot gmail dot com> <CA+6hz4p_693_-Hm=GRsad3ZBAQT=bNXONi5WhbUvei9es6-ydA at mail dot gmail dot com>
On Wed, Jul 08, 2015 at 04:11:19PM +0800, Feng Gao wrote:
> Now I get the reason why the "make check" hang.
> The "make check" need start after make. (I am a little curious why it
> will hang if not make )
>
> But the result is same whatever apply my change or not, it stops the
> same step following:
That is strange - I don't see that. In any case, the generated
libc.so with or without the patch is identical (tested by comparing
outputs of objdump -d libc.so), so I'm going to push this change.
Thanks,
Siddhesh