This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix ruserok scalability with large ~/.rhosts file.

From: Mike Frysinger <vapier at gentoo dot org>
To: Carlos O'Donell <carlos at redhat dot com>
Cc: GNU C Library <libc-alpha at sourceware dot org>
Date: Wed, 8 Jul 2015 02:30:36 -0400
Subject: Re: [PATCH] Fix ruserok scalability with large ~/.rhosts file.
Authentication-results: sourceware.org; auth=none
References: <5582E8CF dot 3030509 at redhat dot com>

On 18 Jun 2015 11:50, Carlos O'Donell wrote:
> --- a/inet/rcmd.c
> +++ b/inet/rcmd.c
>
> +	/* First check the user part.  This is an optimization, since
> +	   one should always check the host first in order to detect
> +	   negative host checks (which we check for later).  */
> +	ucheck = __icheckuser (user, ruser);

the phrasing in this comment sounds confused, or maybe misleading ?

> +	    /* Next check host part */

style is incorrect (period/trailing space)

otherwise patch looks fine to me
-mike

Attachment: signature.asc
Description: Digital signature

Follow-Ups:
- Re: [PATCH] Fix ruserok scalability with large ~/.rhosts file.
  - From: Carlos O'Donell

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]