This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCHv5][PING^3][BZ #17833] _dl_close_worker() does not release inconsistent objects.

From: Pavel Kopyl <p dot kopyl at samsung dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: Yury Gribov <y dot gribov at samsung dot com>, Roland McGrath <roland at hack dot frob dot com>, GNU C Library <libc-alpha at sourceware dot org>, Carlos O'Donell <carlos at redhat dot com>, Viacheslav Garbuzov <v dot garbuzov at samsung dot com>
Date: Wed, 08 Jul 2015 00:32:12 +0300
Subject: Re: [PATCHv5][PING^3][BZ #17833] _dl_close_worker() does not release inconsistent objects.
Authentication-results: sourceware.org; auth=none
References: <54BD4F65 dot 2090108 at samsung dot com> <5553382F dot 3020906 at samsung dot com> <5565B5E5 dot 7060101 at samsung dot com> <CAMe9rOr8yDpnHtRFbL3M56Sx5FWX-FVqEstnwsgtW6H+khvziQ at mail dot gmail dot com> <5565C2A8 dot 60306 at samsung dot com> <CAMe9rOq++pD-ugdYFEte49v8TLZEM505J+=WzPTOT_Lo-MdDHQ at mail dot gmail dot com> <5565C862 dot 1040003 at samsung dot com> <CAMe9rOo7TStj3SX8OK8s3H3G=2Pyr1WKTW=R-=SzVFBWY8PF0A at mail dot gmail dot com> <5566395A dot 3090605 at samsung dot com> <CAMe9rOp4Jrz4AE3-C5VmJ0PLmxoST3phyEQt3t59ag6UGbimBw at mail dot gmail dot com> <5567892C dot 4070004 at samsung dot com> <5568A408 dot 2080903 at samsung dot com> <5592AB91 dot 2050709 at samsung dot com> <CAMe9rOoK64VuNfgZ-8_BTqes0tJcpc55atKw1k6ewBTwFzuGKg at mail dot gmail dot com> <5595C0F8 dot 3060300 at samsung dot com> <CAMe9rOof9j6RwGgNGuxXUgBnYXK0c_UAp3zN2Ne4JhHqiZMFEQ at mail dot gmail dot com> <559B829C dot 8080700 at samsung dot com> <CAMe9rOom4ttO2cGYGovagHpu3zy4L7qn+7E4jm7k=5rD+xgNaQ at mail dot gmail dot com> <559BFDDC dot 4010604 at samsung dot com> <CAMe9rOrf9WQox1bpJSmC1wi2ZpZ+eYBF12bBXUx=-yhD_Yowkg at mail dot gmail dot com>



On 07/07/2015 09:10 PM, H.J. Lu wrote:

On Tue, Jul 7, 2015 at 9:27 AM, Pavel Kopyl <p.kopyl@samsung.com> wrote:


On 07/07/2015 06:30 PM, H.J. Lu wrote:

On Tue, Jul 7, 2015 at 12:41 AM, Yury Gribov <y.gribov@samsung.com> wrote:

On 07/03/2015 02:46 AM, H.J. Lu wrote:

On Thu, Jul 2, 2015 at 3:53 PM, Pavel Kopyl <p.kopyl@samsung.com> wrote:



On 06/30/2015 06:12 PM, H.J. Lu wrote:


On Tue, Jun 30, 2015 at 7:45 AM, Pavel Kopyl <p.kopyl@samsung.com>
wrote:
This patch changes DF_1_NODELETE path.  Do we have a testcase for
sucessfully loading/unloading DF_1_NODELETE DSO with undefined
symbols?

It may have been asked before.  Can we reset unique symbols
in _dl_open before calling _dl_close_worker?

Yes, I added testcases for three possible ways where we can get
DF_1_NODELETE:
1. Unique symbols
2. Load with RTLD_NODELETE flag.
3. Link with '-z nodelete' option

Can we reset unique symbols in _dl_open before calling
_dl_close_worker?

But I clear unique symbols exactly in
_dl_close_worker.<https://slovari.yandex.ru/exactly/en-ru>

Looks good to me.


Folks,

Could someone commit the patch for us?  We do not have write access to
Glibc
repo.  We'll be around to cope with bugs (if any).

Please regenerate the patch with "gcc format-patch" and resubmit it
so that I can do "git am your-patch".

Thanks.

Thanks a lot.

I reformatted your change, fixed ChangeLog entry and added a commit log.
This is what I checked in.

Please provide proper ChangeLog and commit log next time.

Thanks.

Thank you for clarification.
I wonder how should I format patch if I need to mention several authors?

-Pavel

References:
- Re: [PATCHv5][PING^3][BZ #17833] _dl_close_worker() does not release inconsistent objects.
  - From: Pavel Kopyl
- Re: [PATCHv5][PING^3][BZ #17833] _dl_close_worker() does not release inconsistent objects.
  - From: H.J. Lu
- Re: [PATCHv5][PING^3][BZ #17833] _dl_close_worker() does not release inconsistent objects.
  - From: Yury Gribov
- Re: [PATCHv5][PING^3][BZ #17833] _dl_close_worker() does not release inconsistent objects.
  - From: H.J. Lu
- Re: [PATCHv5][PING^3][BZ #17833] _dl_close_worker() does not release inconsistent objects.
  - From: Pavel Kopyl
- Re: [PATCHv5][PING^3][BZ #17833] _dl_close_worker() does not release inconsistent objects.
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]