This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCHv5][PING^3][BZ #17833] _dl_close_worker() does not release inconsistent objects.
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Yury Gribov <y dot gribov at samsung dot com>
- Cc: Roland McGrath <roland at hack dot frob dot com>, Pavel Kopyl <p dot kopyl at samsung dot com>, GNU C Library <libc-alpha at sourceware dot org>, "Carlos O'Donell" <carlos at redhat dot com>, Viacheslav Garbuzov <v dot garbuzov at samsung dot com>
- Date: Tue, 7 Jul 2015 08:30:07 -0700
- Subject: Re: [PATCHv5][PING^3][BZ #17833] _dl_close_worker() does not release inconsistent objects.
- Authentication-results: sourceware.org; auth=none
- References: <54BD4F65 dot 2090108 at samsung dot com> <54BEF851 dot 70902 at redhat dot com> <54DBC3CB dot 5080703 at samsung dot com> <54F071DB dot 9040106 at samsung dot com> <20150301191710 dot GB19363 at vapier> <54F57B52 dot 6080202 at samsung dot com> <553A1BEE dot 6070705 at samsung dot com> <CAMe9rOqiyuyNAtJDZGbfs+0kk0j16-Vowp5f0z_x2zfsd76fMQ at mail dot gmail dot com> <5553382F dot 3020906 at samsung dot com> <5565B5E5 dot 7060101 at samsung dot com> <CAMe9rOr8yDpnHtRFbL3M56Sx5FWX-FVqEstnwsgtW6H+khvziQ at mail dot gmail dot com> <5565C2A8 dot 60306 at samsung dot com> <CAMe9rOq++pD-ugdYFEte49v8TLZEM505J+=WzPTOT_Lo-MdDHQ at mail dot gmail dot com> <5565C862 dot 1040003 at samsung dot com> <CAMe9rOo7TStj3SX8OK8s3H3G=2Pyr1WKTW=R-=SzVFBWY8PF0A at mail dot gmail dot com> <5566395A dot 3090605 at samsung dot com> <CAMe9rOp4Jrz4AE3-C5VmJ0PLmxoST3phyEQt3t59ag6UGbimBw at mail dot gmail dot com> <5567892C dot 4070004 at samsung dot com> <5568A408 dot 2080903 at samsung dot com> <5592AB91 dot 2050709 at samsung dot com> <CAMe9rOoK64VuNfgZ-8_BTqes0tJcpc55atKw1k6ewBTwFzuGKg at mail dot gmail dot com> <5595C0F8 dot 3060300 at samsung dot com> <CAMe9rOof9j6RwGgNGuxXUgBnYXK0c_UAp3zN2Ne4JhHqiZMFEQ at mail dot gmail dot com> <559B829C dot 8080700 at samsung dot com>
On Tue, Jul 7, 2015 at 12:41 AM, Yury Gribov <y.gribov@samsung.com> wrote:
> On 07/03/2015 02:46 AM, H.J. Lu wrote:
>>
>> On Thu, Jul 2, 2015 at 3:53 PM, Pavel Kopyl <p.kopyl@samsung.com> wrote:
>>>
>>>
>>>
>>> On 06/30/2015 06:12 PM, H.J. Lu wrote:
>>>>
>>>>
>>>> On Tue, Jun 30, 2015 at 7:45 AM, Pavel Kopyl <p.kopyl@samsung.com>
>>>> wrote:
>>>> This patch changes DF_1_NODELETE path. Do we have a testcase for
>>>> sucessfully loading/unloading DF_1_NODELETE DSO with undefined
>>>> symbols?
>>>>
>>>> It may have been asked before. Can we reset unique symbols
>>>> in _dl_open before calling _dl_close_worker?
>>>>
>>> Yes, I added testcases for three possible ways where we can get
>>> DF_1_NODELETE:
>>> 1. Unique symbols
>>> 2. Load with RTLD_NODELETE flag.
>>> 3. Link with '-z nodelete' option
>>>
>>>> Can we reset unique symbols in _dl_open before calling _dl_close_worker?
>>>
>>> But I clear unique symbols exactly in
>>> _dl_close_worker.<https://slovari.yandex.ru/exactly/en-ru>
>>>
>>>
>>
>> Looks good to me.
>
>
> Folks,
>
> Could someone commit the patch for us? We do not have write access to Glibc
> repo. We'll be around to cope with bugs (if any).
>
Please regenerate the patch with "gcc format-patch" and resubmit it
so that I can do "git am your-patch".
Thanks.
--
H.J.