This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Clean pthread types namespaces on x86 and x86_64
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Juan Manuel Torres Palma <j dot m dot torrespalma at gmail dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>
- Date: Tue, 23 Jun 2015 21:46:42 +0000
- Subject: Re: [PATCH] Clean pthread types namespaces on x86 and x86_64
- Authentication-results: sourceware.org; auth=none
- References: <CAD82F-p35X2_3PrOo-uKeHUNbsZq=a-dck0xRu9ssOZviAebgA at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1506232014350 dot 22643 at digraph dot polyomino dot org dot uk> <CAD82F-pABzSet3+bjUv-U6+d95LU4+GvSKd=0TZ9k0WkfAdBXw at mail dot gmail dot com>
On Tue, 23 Jun 2015, Juan Manuel Torres Palma wrote:
> > Mechanical patches such as this one are expected to update all
> > architectures to keep the sources bisectable. That includes creating
> > dummy versions of the new headers in the toplevel bits/, like the existing
> > bits/pthreadtypes.h, as well as versions of bits/pthread_st.h (which I
> > think should be bits/thread-shared-types.h) for each architecture that
> > currently has its own bits/pthreadtypes.h,
>
> I planned to update every architecture with a different patch better
> than a single huge one, so it could be tracked down if any issue
> happens since I can only test for x86_64 and ARM. Or do you mean
> creating bits/thread-shared-types.h so other architectures can still
> build? I didn't realize of this last possibility until now...
It's best to keep all architectures in sync at every commit boundary as
far as possible, which means a single patch should make the same change
for all architectures.
--
Joseph S. Myers
joseph@codesourcery.com