This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 13/14] [x86_64] Vector math functions (sincos and tests)


Andrew Senkevich <andrew.n.senkevich@gmail.com> writes:

> 2015-06-19 20:06 GMT+03:00 Joseph Myers <joseph@codesourcery.com>:
>> Preprocessed source might help as well, to show what the code looks like
>> that produces the parse errors and where it appears in the sequence of
>> nested includes.  I wonder if, as well as __DECL_SIMD_sincos_disable,
>> __DECL_SIMD_sincos_disablef and __DECL_SIMD_sincos_disablel need to be
>> defined.
>
> Yes, I also found it through preprocessor output.
>
> diff --git a/ChangeLog b/ChangeLog
> index 7dedfb4..8951f85 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,8 @@
> +2015-06-19  Andrew Senkevich  <andrew.senkevich@intel.com>
> +
> +       * sysdeps/ieee754/ldbl-opt/s_sin.c (__DECL_SIMD_sincos_disable): Added
> +       empty definitions for proper unfolding of __MATHDECL_VEC.
> +
>  2015-06-19  Stefan Liebler  <stli@linux.vnet.ibm.com>
>
>         * benchtests/bench-strcoll.c:
> diff --git a/sysdeps/ieee754/ldbl-opt/s_sin.c b/sysdeps/ieee754/ldbl-opt/s_sin.c
> index a11d5a3..10f5ea7 100644
> --- a/sysdeps/ieee754/ldbl-opt/s_sin.c
> +++ b/sysdeps/ieee754/ldbl-opt/s_sin.c
> @@ -1,5 +1,9 @@
>  /* dbl-64/s_sin.c uses NAN and sincos identifiers internally.  */
>  #define sincos sincos_disable
> +/* Stabs needed for proper unfolding of __MATHDECL_VEC.  */
> +#define __DECL_SIMD_sincos_disable
> +#define __DECL_SIMD_sincos_disablef
> +#define __DECL_SIMD_sincos_disablel
>  #include <math_ldbl_opt.h>
>  #undef NAN
>  #undef sincos

This patch does fix the build error.

Thanks Andrew, Anton and Joseph!

-- 
Tulio Magno


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]