This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 13/14] [x86_64] Vector math functions (sincos and tests)
- From: "Tulio Magno Quites Machado Filho" <tuliom at linux dot vnet dot ibm dot com>
- To: Andrew Senkevich <andrew dot n dot senkevich at gmail dot com>
- Cc: Joseph Myers <joseph at codesourcery dot com>, libc-alpha <libc-alpha at sourceware dot org>, sjmunroe at us dot ibm dot com, Anton Blanchard <anton at samba dot org>
- Cc:
- Date: Fri, 19 Jun 2015 15:06:11 -0300
- Subject: Re: [PATCH 13/14] [x86_64] Vector math functions (sincos and tests)
- Authentication-results: sourceware.org; auth=none
- References: <CAMXFM3t4CRSW2pRELmJMU5bE0eoYfUx7pO2-iLqLiGvgE79d_A at mail dot gmail dot com> <20150619075546 dot 4284b164 at kryten> <CAMXFM3srg-a6+MJQ7btm-wMVUBazEif53EyHbnpv=+RCgAocvA at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1506191124350 dot 24907 at digraph dot polyomino dot org dot uk> <CAMXFM3tzxuVj06vQwWWc4JBXd8MAtLJYOia3mpqViY7w6Bt08g at mail dot gmail dot com> <87vbejhlfr dot fsf at totoro dot br dot ibm dot com> <CAMXFM3sKK_0DKx8hucptOHT6x0sRCkJxNDA+vXCRCjgvGaA55w at mail dot gmail dot com> <87oakbhdov dot fsf at totoro dot br dot ibm dot com> <alpine dot DEB dot 2 dot 10 dot 1506191703360 dot 9752 at digraph dot polyomino dot org dot uk> <CAMXFM3uSTSeWHZe7zDV9rdi_PFtLGj2pLipaOFMzyGPFGZHHQA at mail dot gmail dot com>
Andrew Senkevich <andrew.n.senkevich@gmail.com> writes:
> 2015-06-19 20:06 GMT+03:00 Joseph Myers <joseph@codesourcery.com>:
>> Preprocessed source might help as well, to show what the code looks like
>> that produces the parse errors and where it appears in the sequence of
>> nested includes. I wonder if, as well as __DECL_SIMD_sincos_disable,
>> __DECL_SIMD_sincos_disablef and __DECL_SIMD_sincos_disablel need to be
>> defined.
>
> Yes, I also found it through preprocessor output.
>
> diff --git a/ChangeLog b/ChangeLog
> index 7dedfb4..8951f85 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,8 @@
> +2015-06-19 Andrew Senkevich <andrew.senkevich@intel.com>
> +
> + * sysdeps/ieee754/ldbl-opt/s_sin.c (__DECL_SIMD_sincos_disable): Added
> + empty definitions for proper unfolding of __MATHDECL_VEC.
> +
> 2015-06-19 Stefan Liebler <stli@linux.vnet.ibm.com>
>
> * benchtests/bench-strcoll.c:
> diff --git a/sysdeps/ieee754/ldbl-opt/s_sin.c b/sysdeps/ieee754/ldbl-opt/s_sin.c
> index a11d5a3..10f5ea7 100644
> --- a/sysdeps/ieee754/ldbl-opt/s_sin.c
> +++ b/sysdeps/ieee754/ldbl-opt/s_sin.c
> @@ -1,5 +1,9 @@
> /* dbl-64/s_sin.c uses NAN and sincos identifiers internally. */
> #define sincos sincos_disable
> +/* Stabs needed for proper unfolding of __MATHDECL_VEC. */
> +#define __DECL_SIMD_sincos_disable
> +#define __DECL_SIMD_sincos_disablef
> +#define __DECL_SIMD_sincos_disablel
> #include <math_ldbl_opt.h>
> #undef NAN
> #undef sincos
This patch does fix the build error.
Thanks Andrew, Anton and Joseph!
--
Tulio Magno