This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3][BZ #17787] Fix exponents in manual.
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Carlos O'Donell <carlos at redhat dot com>
- Cc: Ondřej Bílka <neleai at seznam dot cz>, Andreas Schwab <schwab at linux-m68k dot org>, <libc-alpha at sourceware dot org>
- Date: Thu, 18 Jun 2015 16:01:09 +0000
- Subject: Re: [PATCH v3][BZ #17787] Fix exponents in manual.
- Authentication-results: sourceware.org; auth=none
- References: <20150105121124 dot GA20619 at domone> <871tn9joub dot fsf at igel dot home> <20150106115720 dot GA19882 at domone> <20150616175738 dot GD9387 at domone> <alpine dot DEB dot 2 dot 10 dot 1506162002000 dot 31875 at digraph dot polyomino dot org dot uk> <55808614 dot 3060409 at redhat dot com> <20150618142917 dot GA16523 at domone> <alpine dot DEB dot 2 dot 10 dot 1506181434010 dot 31642 at digraph dot polyomino dot org dot uk> <5582E9B2 dot 6060906 at redhat dot com>
On Thu, 18 Jun 2015, Carlos O'Donell wrote:
> > The macro definitions should go in macros.texi, rather than being
> > duplicated in each file using it.
>
> It would also seem sensible to keep such macros near their uses,
> and move them to macros.texi only if globally useful or repeated
> more than some nominal number of times.
>
> What if the macro was only used in one place? Would we still put
> it into macros.texi?
If it were only used in one source file, it might be reasonable to define
it there, but this macro is used in three source files.
Another issue with this patch: where it has "-@twoexp{63}" replacing
"@math{-2^63}", the minus sign being outside @math will make it a hyphen
rather than a minus sign (use @minus{} instead). And one typo,
"-2@twoexp{63}" has a stray "2" in there (should be
"@minus{}@twoexp{63}").
--
Joseph S. Myers
joseph@codesourcery.com